Avoid useless initializations of fci/fcc in array functions #18273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These cause cache misses due to global access, in phpstan (notably the array_map). Initializing these isn't necessary because ZPP initializes it for us. Only for optional arguments do we need to be careful; for `array_filter` we still reset the `fci` but not `fci_cache` because `fci` is not necessarily set by ZPP but is conditionally used to access `fci_cache`.
iluuu1994
reviewed
Apr 8, 2025
iluuu1994
added a commit
to iluuu1994/php-src
that referenced
this pull request
Apr 14, 2025
See php#18273, a constant may cause unnecessary cache misses.
This was referenced Apr 14, 2025
iluuu1994
approved these changes
Apr 15, 2025
|
I guess its related to this PR, therefore posting it here. running phpstan/phpstan-src@b3d3386 on macOS considerable got faster: running 8376904 with
3 runs runtime: vs. running 1684c52a88d with the same command: 3 runs runtime: vs. PHP 8.3.20 (cli) (built: Apr 8 2025 20:21:18) (NTS) 3 runs runtime: vs. PHP 8.4.5 (cli) (built: Mar 12 2025 01:55:56) (NTS) 3 runs runtime: |
|
At least also because of the CALL VM optimization. |
|
Thanks to anyone involved 😎 //cc @arnaud-lb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These cause cache misses due to global access, in phpstan (notably the array_map).
Initializing these isn't necessary because ZPP initializes it for us. Only for optional arguments do we need to be careful; for
array_filterwe still reset thefcibut notfci_cachebecausefciis not necessarily set by ZPP but is conditionally used to accessfci_cache.